Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
T
Tor
Manage
Activity
Members
Labels
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
David Goulet
Tor
Commits
439e1718
Commit
439e1718
authored
3 years ago
by
Nick Mathewson
Browse files
Options
Downloads
Patches
Plain Diff
Light edit to protover warnings.
parent
f93cd5de
No related branches found
No related tags found
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/core/or/protover.c
+8
-7
8 additions, 7 deletions
src/core/or/protover.c
with
8 additions
and
7 deletions
src/core/or/protover.c
+
8
−
7
View file @
439e1718
...
...
@@ -402,18 +402,19 @@ protover_get_supported_protocols(void)
* If you need to remove a version from this list, you need to make sure that
* it is not listed in the _current consensuses_: just removing it from the
* required list below is NOT ENOUGH. You need to remove it from the
* required list, and THEN let the authorities up
dat
e and vote on new
* required list, and THEN let the authorities up
grad
e and vote on new
* consensuses without it. Only once those consensuses are out is it safe to
* remove from this list.
*
* One concrete example of a very dangerous race that could occur:
*
* If the client required protocol "HSDir=1-2" is then changed in the code
* and released to "HSDir=2" while the consensus stills lists "HSDir=1-2",
* then these clients, even very recent ones, will shutdown because they
* Suppose that the client supports protocols "HsDir=1-2" and the consensus
* requires protocols "HsDir=1-2. If the client supported protocol list is
* then changed to "HSDir=2", while the consensus stills lists "HSDir=1-2",
* then these clients, even very recent ones, will shut down because they
* don't support "HSDir=1".
*
* And so, changes need to be done in
lockstep
as described above.
* And so, changes need to be done in
strict sequence
as described above.
*
* XXX: WARNING!
*/
...
...
@@ -454,8 +455,8 @@ protover_get_supported_protocols(void)
* network unless their presence is causing serious active harm.
*
* The following required and recommended lists MUST be changed BEFORE the
* supported list above is changed
in order for
th
o
se lists
to
appear in the
* consensus BEFORE.
* supported list above is changed
, so that
th
e
se lists appear in the
* consensus BEFORE
clients need them
.
*
* Please, see the warning in protocol_get_supported_versions().
*
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment