Commit 24b7b922 authored by Nick Mathewson's avatar Nick Mathewson 🤹
Browse files

Actually free the worker_state_t object when we do an update with it 

Previously we freed the old "keys" object, but leaked the
worker_state_t that we had taken it from.

Fixes bug 20401; bugfix on 0.2.6.3-alpha.
parent d2887040

changes/bug20401

0 → 100644
+4 −0
Original line number Diff line number Diff line 
  o Minor bugfixes (relay):

    - Avoid a small memory leak when informing worker threads about rotated

      onion keys. Fixes bug 20401; bugfix on 0.2.6.3-alpha.

src/or/cpuworker.c

+1 −0
Original line number Diff line number Diff line
@@ -168,6 +168,7 @@ update_state_threadfn(void *state_, void *work_) 
  server_onion_keys_free(state->onion_keys);

  state->onion_keys = update->onion_keys;

  update->onion_keys = NULL;

  worker_state_free(update);

  ++state->generation;

  return WQ_RPL_REPLY;

}