Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
T
tor
Manage
Activity
Members
Code
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package registry
Container registry
Model registry
Operate
Terraform modules
Analyze
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
jarl
tor
Commits
fde4129a
Commit
fde4129a
authored
20 years ago
by
Nick Mathewson
Browse files
Options
Downloads
Patches
Plain Diff
Resolve FIXME items: clarify two XXXX comments for 009
svn:r2791
parent
aa1c0c4d
Branches
Branches containing commit
Tags
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
src/or/circuitbuild.c
+8
-2
8 additions, 2 deletions
src/or/circuitbuild.c
with
8 additions
and
2 deletions
src/or/circuitbuild.c
+
8
−
2
View file @
fde4129a
...
...
@@ -350,9 +350,14 @@ circuit_deliver_create_cell(circuit_t *circ, char *payload) {
tor_assert
(
circ
->
n_conn
->
type
==
CONN_TYPE_OR
);
tor_assert
(
payload
);
/* XXXX00
8
How can we keep a good upgrade path here? We should
/* XXXX00
9
How can we keep a good upgrade path here? We should
* compare keys, not nicknames...but older servers will compare nicknames.
* Should we check server version from the most recent directory? Hm.
*
* This is important if anybody is unverified.
*
* Solution: switch to identity-based comparison, but if we get
* any circuits in the wrong half of the space, switch.
*/
circ_id_type
=
decide_circ_id_type
(
get_options
()
->
Nickname
,
circ
->
n_conn
->
nickname
);
...
...
@@ -1062,7 +1067,8 @@ static int count_acceptable_routers(smartlist_t *routers) {
}
if
(
r
->
is_verified
==
0
)
{
log_fn
(
LOG_DEBUG
,
"Nope, the directory says %d is not verified."
,
i
);
goto
next_i_loop
;
/* XXX008 */
/* XXXX009 But unverified routers *are* sometimes acceptable. */
goto
next_i_loop
;
}
num
++
;
log_fn
(
LOG_DEBUG
,
"I like %d. num_acceptable_routers now %d."
,
i
,
num
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment