Closes #20938

Signed-off-by: David Goulet <dgoulet@torproject.org>

Makes 19926 less annoying in 0.2.9.  In 0.3.0, we should actually
fix this.

David Goulet authored 8 years ago and Nick Mathewson committed 8 years ago

The signed_descriptor_move() was not releasing memory inside the destination
object before overwriting it with the source object. This commit adds a reset
function that free that memory inside a signed descriptor object and zero it.

Closes #20715.

Signed-off-by: David Goulet <dgoulet@torproject.org>

"Ours" merge to avoid bumping version.

cypherpunks authored 8 years ago and Nick Mathewson committed 8 years ago

Also combine all of the checks into one if-tree as only one of them
should actually succeed.

(ours merge, to avoid taking 20865 fix)

They added clock_gettime(), but with tv_nsec as a long, whereas
tv_usec is a __darwin_suseconds_t (a.k.a. 'int').  Now, why would
they do that? Are they preparing for a world where there are more
than 2 billion nanoseconds per second?  Are they planning for having
int be less than 32 bits again?  Or are they just not paying
attention to the Darwin API?

Also, they forgot to mark clock_gettime() as Sierra-only, so even
if we fixed the issue here, we'd still be stick with portability
breakage like we were for 0.2.9.

So, just disable clock_gettime() on apple.

Attempted fix for 19960.

Also, fixes a typo.

This is an attempt to figure out what's up with #19960

Fixes 20875; this code is as suggested by teor on the ticket.  Thanks!

This is an attempt to fix #19974.

Tor 0.2.9 has a broader range of fixes and workarounds here, but for
0.2.8, we're just going to maintain the existing behavior.

(The alternative would be to backport both
1eba0880 and
16fcbd21 , but the latter is kind of
a subtle kludge in the configure.ac script, and I'm not a fan of
backporting that kind of thing.)

J. Ryan Stinnett authored 8 years ago and Nick Mathewson committed 8 years ago

Fixes #20492.

(OpenSSL 1.1 makes EVP_CIPHER_CTX opaque, _and_ adds acceleration
for counter mode on more architectures.  So it won't work if we try
the older approach, and it might help if we try the newer one.)

Fixes bug 20588.

We were freeing both dir{1,2} directly, and service_{1,2}->directory via
rend_service_free, even though they are the same pointer.

This pattern is much less error-prone when future changes are made.

David Goulet authored 8 years ago and Nick Mathewson committed 8 years ago

When computing old Tor protocol line version in protover, we were looking at
0.2.7.5 twice instead of the specific case for 0.2.9.1-alpha.

Fixes #20810

Signed-off-by: David Goulet <dgoulet@torproject.org>