Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
S
sbws
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Container Registry
Model registry
Operate
Environments
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
juga
sbws
Commits
68eb23a4
Commit
68eb23a4
authored
6 years ago
by
Matt Traudt
Browse files
Options
Downloads
Patches
Plain Diff
Fix .join needing only strs; first changelog entry
parent
6988eee3
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
CHANGELOG.md
+18
-1
18 additions, 1 deletion
CHANGELOG.md
sbws/lib/circuitbuilder.py
+1
-1
1 addition, 1 deletion
sbws/lib/circuitbuilder.py
with
19 additions
and
2 deletions
CHANGELOG.md
+
18
−
1
View file @
68eb23a4
This file will be populated once we hit 1.0.0
# Changelog
All notable changes to this project will be documented in this file.
The format is based on
[
Keep a Changelog
](
http://keepachangelog.com/en/1.0.0/
)
and this project adheres to
[
Semantic Versioning
](
http://semver.org/spec/v2.0.0.html
)
.
## [Unreleased]
### Fixed
-
Exception that causes sbws to fall back to one measurement thread. We first
tried fixing something in this area with
`88fae60bc`
but neglected to
remember that
`.join()`
wants only string arguments and can't handle a
`None`
.
So fix that.
[
Unreleased
]:
https://github.com/pastly/simple-bw-scanner/v0.4.0...master
This diff is collapsed.
Click to expand it.
sbws/lib/circuitbuilder.py
+
1
−
1
View file @
68eb23a4
...
...
@@ -164,7 +164,7 @@ class GapsCircuitBuilder(CircuitBuilder):
insert_relays
=
self
.
_random_sample_relays
(
num_missing
,
[
r
for
r
in
path
if
r
is
not
None
])
if
insert_relays
is
None
:
path
=
'
,
'
.
join
([
r
.
nickname
if
r
else
None
for
r
in
path
])
path
=
'
,
'
.
join
([
r
.
nickname
if
r
else
str
(
None
)
for
r
in
path
])
log
.
warning
(
'
Problem building a circuit to satisfy %s with available
'
'
relays in the network
'
,
path
)
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment