Skip to content
Snippets Groups Projects

Bug 33009 v5

Closed juga requested to merge bug_33009_v5 into maint-1.1
All threads resolved!

Merge request reports

Loading
Loading

Activity

Filter activity
  • Approvals
  • Assignees & reviewers
  • Comments (from bots)
  • Comments (from users)
  • Commits & branches
  • Edits
  • Labels
  • Lock status
  • Mentions
  • Merge request status
  • Tracking
  • Author Owner

    lgtm :)

    i didn't think about calculating in a separate way the min bw for exits and non-exits but i think it's better like this, since exits have higher bw.

    i left a comment over the code, just to use this gl functionality ;)

    By juga on 2020-04-08T13:33:05 (imported from GitLab project)

  • juga resolved all threads

    resolved all threads

    By Georg Koppen on 2020-04-09T06:18:02 (imported from GitLab project)

  • juga resolved all threads

    resolved all threads

    By Georg Koppen on 2020-04-09T06:18:40 (imported from GitLab project)

    • Author Owner
      Resolved by juga

      Thanks, good idea to show me the "leave a comment over the code" functionality, thanks. FWIW Ithought it's good to keep things simple which is just calculating the bw once for the exits and use it everywhere. I doubt using the non-exit bw would make a big difference and would merit the extra complexity.

      By Georg Koppen on 2020-04-09T16:00:05 (imported from GitLab project)

  • juga resolved all threads

    resolved all threads

    By Georg Koppen on 2020-04-09T16:23:48 (imported from GitLab project)

  • closed

    By Georg Koppen on 2020-04-14T13:42:37 (imported from GitLab project)

  • juga mentioned in merge request !6 (merged)

    mentioned in merge request !6 (merged)

    By juga on 2020-04-14T13:47:53 (imported from GitLab project)

  • Please register or sign in to reply
    Loading