Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
T
tor-browser-bundle
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Wiki
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Build
Pipelines
Jobs
Pipeline schedules
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Keyboard shortcuts
?
Snippets
Groups
Projects
This is an archived project. Repository and other project resources are read-only.
Show more breadcrumbs
Legacy
gitolite
user
sebastian
tor-browser-bundle
Commits
a11a8b30
Commit
a11a8b30
authored
7 years ago
by
Georg Koppen
Browse files
Options
Downloads
Patches
Plain Diff
Apply patch for bug 23044
parent
fb678ac1
No related branches found
No related tags found
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
gitian/descriptors/linux/gitian-firefox.yml
+2
-0
2 additions, 0 deletions
gitian/descriptors/linux/gitian-firefox.yml
gitian/patches/gio.patch
+48
-0
48 additions, 0 deletions
gitian/patches/gio.patch
with
50 additions
and
0 deletions
gitian/descriptors/linux/gitian-firefox.yml
+
2
−
0
View file @
a11a8b30
...
@@ -33,6 +33,7 @@ files:
...
@@ -33,6 +33,7 @@ files:
-
"
gcc-linux32-utils.zip"
-
"
gcc-linux32-utils.zip"
-
"
gcc-linux64-utils.zip"
-
"
gcc-linux64-utils.zip"
-
"
get-moz-build-date"
-
"
get-moz-build-date"
-
"
gio.patch"
-
"
re-dzip.sh"
-
"
re-dzip.sh"
-
"
dzip.sh"
-
"
dzip.sh"
-
"
versions"
-
"
versions"
...
@@ -88,6 +89,7 @@ script: |
...
@@ -88,6 +89,7 @@ script: |
mkdir -p $INSTDIR/Debug/Browser/
mkdir -p $INSTDIR/Debug/Browser/
cd tor-browser
cd tor-browser
patch -p1 < ../gio.patch
# run get-moz-build-date before removing .git, which is used to get the year
# run get-moz-build-date before removing .git, which is used to get the year
chmod +x ~/build/get-moz-build-date
chmod +x ~/build/get-moz-build-date
eval $(~/build/get-moz-build-date $(cat browser/config/version.txt))
eval $(~/build/get-moz-build-date $(cat browser/config/version.txt))
...
...
This diff is collapsed.
Click to expand it.
gitian/patches/gio.patch
0 → 100644
+
48
−
0
View file @
a11a8b30
From a96f898e0da42de751a5e1367a9899cc96fadb1f Mon Sep 17 00:00:00 2001
From: Georg Koppen <gk@torproject.org>
Date: Thu, 27 Jul 2017 07:31:38 +0000
Subject: [PATCH] Bug 23044: Don't allow GIO supported protocols by default
diff --git a/browser/app/profile/000-tor-browser.js b/browser/app/profile/000-tor-browser.js
index aaeba630422d..3edaad88f59e 100644
--- a/browser/app/profile/000-tor-browser.js
+++ b/browser/app/profile/000-tor-browser.js
@@ -210,6 +210,9 @@
pref("network.protocol-handler.warn-external.mailto", true);
pref("network.protocol-handler.warn-external.news", true);
pref("network.protocol-handler.warn-external.nntp", true);
pref("network.protocol-handler.warn-external.snews", true);
+// Make sure we don't have any GIO supported protocols (defense in depth
+// measure)
+pref("network.gio.supported-protocols", "");
pref("plugin.disable", true); // Disable to search plugins on first start
pref("plugins.click_to_play", true);
pref("plugin.state.flash", 1);
diff --git a/extensions/gio/nsGIOProtocolHandler.cpp b/extensions/gio/nsGIOProtocolHandler.cpp
index a378e8700821..5f6b2a0a2a57 100644
--- a/extensions/gio/nsGIOProtocolHandler.cpp
+++ b/extensions/gio/nsGIOProtocolHandler.cpp
@@ -922,16 +922,16 @@
nsGIOProtocolHandler::InitSupportedProtocolsPref(nsIPrefBranch *prefs)
// Get user preferences to determine which protocol is supported.
// Gvfs/GIO has a set of supported protocols like obex, network, archive,
// computer, dav, cdda, gphoto2, trash, etc. Some of these seems to be
- // irrelevant to process by browser. By default accept only smb and sftp
- // protocols so far.
+ // irrelevant to process by browser. By default accept none.
nsresult rv = prefs->GetCharPref(MOZ_GIO_SUPPORTED_PROTOCOLS,
getter_Copies(mSupportedProtocols));
if (NS_SUCCEEDED(rv)) {
mSupportedProtocols.StripWhitespace();
ToLowerCase(mSupportedProtocols);
}
- else
- mSupportedProtocols.AssignLiteral("smb:,sftp:"); // use defaults
+ else {
+ mSupportedProtocols.AssignLiteral(""); // use none by default
+ }
LOG(("gio: supported protocols \"%s\"\n", mSupportedProtocols.get()));
}
--
2.13.2
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment