Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #10478

Closed (moved)
Open
Opened Dec 23, 2013 by Nick Mathewson@nickm🥄

Use prepend_policy or similar in preference to mark_circuit_unusable_for_new_conns

For some error cases, probably including END_STREAM_REASON_TIMEOUT, END_STREAM_REASON_RESOLVEFAILED, END_STREAM_REASON_CONNECTREFUSED, our current practice of tracking failures with client_dns_incr_failures and marking the whole circuit as unusable for connections is probably no good.

After all, a TIMEOUT can just mean that the particular address was filtered, or that it legitimately timed out, or something like that.

Instead, we should use prepend_policy or some similar mechanism to mark that circuit, not as unsuitable for all new streams, but as simply unsuitable for the particular address. (I say "something like prepend_policy" and not "prepend_policy" because we should really drop the original hostname and not just the resolved address.) We might want to keep a counter of the number of successful and failed streams per circuit.

This is going to be important if we make more failure types retriable (#7870 (moved)).

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#10478