`nsILocalFile` should be replaced with `nsIFile` in our extensions

Warning: Starting with Gecko 14, `nsILocalFile` inherits all functions and attributes from `nsIFile`, meaning that you no longer need to use `nsILocalFile`. If your add-on doesn't support versions older than 14, you should use `nsIFile` instead of `nsILocalFile`.

See bug https://bugzilla.mozilla.org/show_bug.cgi?id=682360 for more information.
components/tl-protocol.js
{
  var file = Cc['@mozilla.org/file/local;1'].createInstance(Ci.nsILocalFile);
  file.initWithPath(aPath);

added TorBrowserTeam201712R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::minor status::closed tbb-easy type::defect labels

Trac:
Cc: N/A to mcs

Trac:
Keywords: N/A deleted, tbb-easy added

This ticket includes the Torbutton related stuff, too, now (see #10574 (moved)).

Trac:
Owner: brade to tbb-team
Component: Tor Launcher to Tor Browser
Summary: nsILocalFile should be replaced with nsIFile to nsILocalFile should be replaced with nsIFile in our extensions

Hey!! I am a beginner ! Can I work on this?

Trac:
Username: aruna1234
Reviewer: N/A to N/A
Sponsor: N/A to N/A
Severity: N/A to Blocker

Sure, go ahead!

Trac:
Severity: Blocker to Minor

Actually, I am not able to find the block of code that needs editing. Could you help me through?

Trac:
Username: aruna1234

Replying to aruna1234:

Actually, I am not able to find the block of code that needs editing. Could you help me through? https://gitweb.torproject.org/tor-launcher.git/tree/src/components/tl-protocol.js#n1354

Trac:
Status: new to needs_review

Thanks aruna1234: Could you create a proper git patch for review? The commit message should contain the bug number and what you did, for instance "Bug 10573: Replace deprecated nsILocalFile with nsIFile".

You can start by cloning the code repositories we use, for Tor Launcher you could do git clone https://git.torproject.org/tor-launcher and then you write your patch and commit it that repository. You can then create a properly formatted patch by running git format-patch -p -1 and attach that one for review.

It seems to me we have a similar issue in our Torbutton code. You can fix similarly by starting with cloning the Torbutton repository with git clone https://git.torproject.org/torbutton.

Trac:
Status: needs_review to needs_revision

Seems you attached the wrong patch? Please have a look at the Torbutton code as well, there should be another instance of nsILocalFile.

I know the files are these: components/cookie-jar-selector.js chrome/content/torbutton.js Could you mention the line number.

Also will there be three .patch files then?

Trac:
Username: aruna1234

Replying to aruna1234:

I know the files are these: components/cookie-jar-selector.js chrome/content/torbutton.js Could you mention the line number.

You question confuses me. If you found the files you should be able to find the lines to change....

Also will there be three .patch files then?

We would like to receive one git format-patch file per git repository, in this case one for Torbutton and one for Tor Launcher. Thanks!

Thanks! I think "Bug 10573: Replace deprecated nsILocalFile with nsIFile" would be a good commit message for both patches.

Trac:
Username: aruna1234

0001-Bug-10573-Replace-deprecated-nsILocalFile-with-nsIFi.3.patch

Trac:
Username: aruna1234

Trac:
Status: needs_revision to needs_review
Keywords: N/A deleted, TorBrowserTeam201712R added

aruna1234, can you please delete the attachments that are not needed so that only the ones that should be reviewed remain on this ticket? Thanks!

actually I am unable to find where is the functionality for deleting an attachment.

Trac:
Username: aruna1234

Replying to mcs:

aruna1234, can you please delete the attachments that are not needed so that only the ones that should be reviewed remain on this ticket? Thanks!

I deleted them.

thanks for the help!

Trac:
Username: aruna1234

I think we are missing the Tor Launcher patch now. The two remaining attachments contain the same patch; the second has a corrected bug number in the commit message.

Replying to mcs:

I think we are missing the Tor Launcher patch now. The two remaining attachments contain the same patch; the second has a corrected bug number in the commit message.

Indeed, my bad. aruna1234: could you add the Tor Launcher patch again? Thanks!

Trac:
Keywords: TorBrowserTeam201712R deleted, TorBrowserTeam201712 added
Status: needs_review to needs_revision

Trac:
Username: aruna1234

0001-Bug-10573-Replace-deprecated-nsILocalFile-with-nsIFi.patch

Trac:
Username: aruna1234

Trac:
Status: needs_revision to needs_review
Keywords: TorBrowserTeam201712 deleted, TorBrowserTeam201712R added

Thanks. This is commit d3c99991b207bb51dcaf477e2d879eb2234282a0 on master in Torbutton and commit e24ab106dffdf4f0504c2f60005e213ebd47d458 on master in Tor Launcher.

Trac:
Status: needs_review to closed
Resolution: N/A to fixed

closed

mentioned in issue #10574 (moved)

moved to tpo/applications/tor-browser#10573 (closed)