Make use of HeapEnableTerminationOnCorruption in Tor Browser on Windows

This function gets defined in ipc/chromium/src/base/process_util* but is only used in the test suite: https://mxr.mozilla.org/mozilla-esr24/source/ipc/chromium/src/base/test_suite.h. We should make more use of it in the code itself. See: https://blogs.msdn.com/b/oldnewthing/archive/2013/12/27/10484882.aspx for more information.

added TorBrowserTeam201704R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::major status::closed tbb-easy tbb-firefox-patch tbb-hardened tbb-security type::enhancement labels

Trac:
Owner: mikeperry to tbb-team
Component: Firefox Patch Issues to Tor Browser
Keywords: N/A deleted, tbb-firefox-patch added

Trac:
Cc: N/A to tom@ritter.vg

Trac:
Keywords: N/A deleted, tbb-hardening added

Trac:
Keywords: tbb-hardening deleted, tbb-hardened added

One system function call that should have been applied long long ago. (For tor.exe and others, please, too.) https://bugzilla.mozilla.org/show_bug.cgi?id=805173 P.S. It is not necessary for applications to enable it since Win 8 because the system uses it for all processes by default.

Trac:
Sponsor: N/A to N/A
Reviewer: N/A to N/A
Severity: N/A to Major
Keywords: N/A deleted, tbb-easy, TorBrowserTeam201704R added
Status: new to needs_review
Summary: Make use of EnableTerminationOnHeapCorruption() in Tor Browser to Make use of HeapEnableTerminationOnCorruption in Tor Browser on Windows

Okay, I cherry-picked that patch from gecko-dev/master. It is commit 49d21424d9d25b47a263bacec751742ac7370683 on tor-browser-52.0.2esr-7.0-2.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

FWIW: We want to test it an alpha but think harder if we should pick that one for the 7.0 stable in case we don't get the sandbox compiled properly in time.

Replying to gk:

FWIW: We want to test it an alpha but think harder if we should pick that one for the 7.0 stable in case we don't get the sandbox compiled properly in time. ??? It has been tested in stable since 2012 when Win 8 was released which terminated all processes on heap corruption by default without any need for asking it through HeapSetInformation() calls. It is needed only for Win 7 or earlier. Would be nice to see it in 6.5 (in tor.exe near SetProcessDEPPolicy() too). FWIW: we should also add EnableLowFragmentationHeap() modified from https://dxr.mozilla.org/mozilla-esr24/source/ipc/chromium/src/base/process_util_win.cc#867, but it's not so easy.

closed

mentioned in issue #21953 (moved)

mentioned in issue #22315 (moved)

mentioned in issue tpo/core/tor#21953 (closed)

moved to tpo/applications/tor-browser#12426 (closed)

mentioned in issue tpo/applications/tor-browser#22315 (closed)