Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #12512

Closed (moved)
Open
Opened Jul 02, 2014 by cypherpunks@cypherpunks

Two source files are executable

A casual ls -l on src/or highlighted two source files (control.c and router.c) as being executable. With the command find -executable -type f | grep "\.[c|h]$" it turned out these were the only two files with this anomaly. The change was made in commit 51e13cd1ad5f7c130521e2a964ea462f35d1880e.

The patch would be:

diff --git a/src/or/control.c b/src/or/control.c
old mode 100755
new mode 100644
diff --git a/src/or/router.c b/src/or/router.c
old mode 100755
new mode 100644
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.2.5.x-final
Milestone
Tor: 0.2.5.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#12512