Apply mixed content blocking patch?

There is a mostly-finished patch to improve the mixed content blocker to properly handle redirects. This patch would allow many more HTTPS-Everywhere rules to work properly with the Mixed Content Blocker enabled. We should see if we can help clean this patch up, if nothing else to make it work for us.

https://bugzilla.mozilla.org/show_bug.cgi?id=878890

added component::applications/tor browser owner::tbb-team priority::medium severity::normal status::new tbb-security type::task labels

Trac:
Cc: arthuredelstein to arthuredelstein, gk

Trac:
Keywords: TorBrowserTeam201410D deleted, TorBrowserTeam201410D tbb-esr31 added

Trac:
Keywords: TorBrowserTeam201410D tbb-esr31 deleted, TorBrowserTeam201410D ff31-esr added

If we get an alpha out, we can consider trying to land these patches in it, but otherwise backporting these patches this month is not a hard deadline.

Trac:
Keywords: TorBrowserTeam201410D ff31-esr deleted, TorBrowserTeam201410 ff31-esr added

Trac:
Keywords: TorBrowserTeam201410 ff31-esr deleted, TorBrowserTeam201410 added

Trac:
0001-Bug-13033-Backport-for-Redirects-should-go-through-M.patch

The Mozilla patch landed, so I backported it to tor-browser-31.2.0esr-4.x-1. The individual patches are here: https://github.com/arthuredelstein/tor-browser/commits/13033 and I've attached a squashed version as a single patch file.

Trac:
Status: new to needs_review

Trac:
Keywords: N/A deleted, tbb-4.5-alpha added

Crap. I messed this bug up by linking to the wrong Mozilla bug. I'm really sorry about that. The patch we want to backport is https://bugzilla.mozilla.org/show_bug.cgi?id=878890.

I've updated the description, too.

Trac:
Status: needs_review to new
Description: There is a mostly-finished patch to improve the mixed content blocker to properly handle redirects. This patch would allow many more HTTPS-Everywhere rules to work properly with the Mixed Content Blocker enabled. We should see if we can help clean this patch up, if nothing else to make it work for us.

https://bugzilla.mozilla.org/show_bug.cgi?id=418354

to

There is a mostly-finished patch to improve the mixed content blocker to properly handle redirects. This patch would allow many more HTTPS-Everywhere rules to work properly with the Mixed Content Blocker enabled. We should see if we can help clean this patch up, if nothing else to make it work for us.

https://bugzilla.mozilla.org/show_bug.cgi?id=878890
Keywords: tbb-4.5-alpha deleted, N/A added

Also, since that patch doesn't look like it's progressed much since the first version, I'm taking this off our radar for now, and moving it to tbb-security.

Trac:
Keywords: TorBrowserTeam201410 deleted, tbb-security added

Replying to mikeperry:

Crap. I messed this bug up by linking to the wrong Mozilla bug. I'm really sorry about that. The patch we want to backport is https://bugzilla.mozilla.org/show_bug.cgi?id=878890.

No worries!

Set all open tickets without a severity to "Normal"

Trac:
Severity: N/A to Normal

mentioned in issue #13747 (moved)

mentioned in issue #21323 (moved)

moved to tpo/applications/tor-browser#13033 (closed)