Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #13079
Closed (moved) (moved)
Open
Issue created Sep 07, 2014 by proper@proper

environment variable to skip TorButton control port verification

Tor Button now does its own Tor ControlPort verification.

Source #6546 comment:33 mikeperry:

TBB now performs its own control port verification. We simply check that the socks port Tor says its on is the one Firefox is configured to use.

If that test fails, the default homepage about:tor will show:

Something Went Wrong!
Tor is not working in this browser.

This is problematic in transparent / isolating proxy environments, that do not wish to allow ControlPort access for security reasons (getinfo address and other dangerous ControlPort commands).

The test is implemented in torbrowser.js, in function torbutton_local_tor_check().

[...]
  const kCmdArg = "net/listeners/socks";
[...]
  let resp = torbutton_send_ctrl_cmd("GETINFO " + kCmdArg + "\r\n");
[...]

(The environment variable TOR_SKIP_LAUNCH=1 does not prevent this. [No such variable in Tor Button's source code.])

It would be nice if there was an environment variable such as TOR_SKIP_CONTROLPORTTEST (or so), that would skip this test.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking