Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #13581

Closed
Open
Created Oct 26, 2014 by Ximin Luo@infinity0

bin/* should avoid hacking sys.path

bin/ooni{deckgen,probe,report,resources} currently hacks sys.path to add the current working directory. I am guessing this is done so developers can run bin/ooniprobe from a source checkout, and have python still able to find the ooni python modules.

However, this is a security hole if ooniprobe has extra capabilities (e.g. in the setuid wrapper I'm writing, so that ooni itself doesn't have to run as root) - the user can add their own ./ooni/etc fake modules, which will run with these extra capabilities.

It's also not a clean design to add development-specific hacks to production deployed code. For example in flashproxy, we have a similar problem and we solve it differently: https://gitweb.torproject.org/flashproxy.git/blob/HEAD:/facilitator/HACKING

or devs should do exactly what is done in production which is... run the program in a docker image

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking