Skip to content

GitLab

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

Closed (moved)
Opened by Mike Perry@mikeperry

Can we compile in WebRTC to allow QRCode bridge entry?

We should evaluate if we can re-enable the compilation of WebRTC in Tor Browser. There are two reasons for this:

  1. Mozilla may remove the WebRTC compile time switch of WebRTC in future builds.
  2. Enabling WebRTC at compile time may enable Tor Launcher to make use of the WebCam for scanning QRCodes of bridges (see #14837 (moved)).

Mozilla's security team claims that setting media.peerconnection.enabled to false will completely disable content access to all WebRTC APIs, which should be sufficient for us. However, my review of the FF31 source showed that several other things get compiled in to the browser that may or may not be directly tied to the peerconnection APIs. For example RTSP and SCTP protocol support gets compiled in, and there may be other ways to use these protocols elsewhere in the browser. See: https://gitweb.torproject.org/tor-browser-spec.git/tree/audits/FF31_NETWORK_AUDIT

FWIW, simple PoC's such as https://diafygi.github.io/webrtc-ips/ fail if media.peerconnection.enabled is unset, but again, more investigation is needed.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information