Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #1564

Closed (moved)
(moved)
Open
Created Jun 17, 2010 by Karsten Loesing@karsten

Reported dirreq-v3-stats are 0.00%

Since late May 2010, the dirreq-v3-stats that directory mirrors report are very low or even 0.00%. Mike has identified the cause for this bug:

For the love of Chaos, router_get_my_share_of_directory_requests() is the dirtiest hack I've seen in a while, no wonder it broke :)

Your problem is that the global variables you rely on are not set by smartlist_choose_by_bandwidth_weights(), which is the new implementation of the weighted selection algorithm. They are only set by smartlist_choose_by_bandwidth(). You could update smartlist_choose_by_bandwidth_weights() to set those variables, but man, there's got to be a better way :)

We should investigate new approaches to calculate directory request shares from the descriptor archives instead of believing in what directories tell us. Afterwards, we can decide whether to fix dirreq-v3-stats in Tor, or to take them out entirely.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking