Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Packages and registries
    • Packages and registries
    • Container Registry
    • Model experiments
  • Monitor
    • Monitor
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #15642

Disable default fallback directories when DirAuthorities, AlternateDirAuthority, or FallbackDir are set

Currently, when we set DirAuthorities or AlternateDirAuthority, we don't add the default directory authorities. But, (as long as FallbackDir isn't set) we do add the default fallback directories.

It doesn't make sense to me to add the default fallback directories when we have custom DirAuthorities or AlternateDirAuthority. I think we should only add the default fallback directories when other directories are also set to their defaults.

However, the list of default fallback directories is currently NULL, so this issue currently has no effect.

I also can't imagine any scenarios where it would be useful to set an AlternateDirAuthority or DirAuthorities, and still get the default FallbackDir.

I can imagine this causing similar issues to #13163 (moved), where the default authorities were added to a custom set of authorities in some circumstances.

I'll create a patch to fix this, but it won't actually change tor's observable behaviour until we add directories to the default fallback directory list.

Bugfix on 90f6071d8dc0 in 0.2.4.7-alpha.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking