Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #15852

Closed (moved)
Open
Opened Apr 28, 2015 by Mike Perry@mikeperry

Remove/synchronize Torbutton SOCKS pref logic

In 4.5 (#14630 (moved)), we removed the Torbutton settings window because I assumed that users could use the Firefox proxy setting instead. Unfortunately, Torbutton still has code to check if its SOCKS settings match the browser proxy settings, and to disable itself if these are out of sync.

We should remove this old code so that it is easier for people to point TBB at a different Tor instance. The code is a toggle-era relic, and we have a control port check anyway.

We should also ensure that if the Tor check fails, Torbutton's features aren't actually disabled, and that the difference is only a cosmetic warning. Right now, I fear that features are actually disabled, due to other toggle-era checks.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#15852