Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #17779

Closed (moved)
Open
Opened Dec 08, 2015 by cypherpunks@cypherpunks

Memory leak in routerkeys.c

The rsa_ed_crosscert variable is assigned a cross-certification object in the load_ed_keys function but is never freed. Secondly, the variable is only used by the get_master_rsa_crosscert function which, in turn, is not used by the current code base.

My suggestion is to remove the rsa_ed_crosscert variable and the get_master_rsa_crosscert function to fix the memory leak (unless they have some future use-case).

The variable and function were added in 3bee74c6d115131f4850a07a5c12db21ae6f3193.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: 0.2.9.x-final
Milestone
Tor: 0.2.9.x-final
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#17779