Use ClientIPv4 and ClientIPv6 to select a bridge address

If a bridge has an IPv4 and an IPv6 address, and a tor client knows both, it should select the address family based on the values of:

• ClientUseIPv4
• ClientUseIPv6
• ClientPreferIPv6ORPort ?

(I don't think ClientPreferIPv6DirPort is relevant here.)

This code works as-is, so I don't see any reason to change it urgently.

changed milestone to %Tor: 0.2.9.x-final

added bridges component::core tor/tor ipv6 milestone::Tor: 0.2.9.x-final parent::17963 priority::low resolution::fixed severity::minor sponsor::S-can status::closed tor-bridge type::enhancement labels

After #17840 (moved), we could do this by modifying the new function fascist_firewall_choose_address_base:

• use ClientPreferIPv6ORPort to choose a preferred address for bridge clients,
• but ignore the "preferred address only setting", so that bridge users always get an address if there is one available.

Bridge clients use IPv6 when they can because it's not as censored. I don't think we want to change this. (But perhaps by user config?)

#17963 (moved) will resolve this as part of making bridge clients use IPv6 for directory queries.

Trac:
Parent: #17811 (moved) to #17963 (moved)
Milestone: Tor: 0.2.9.x-final to Tor: 0.2.8.x-final

It is impossible that we will fix all 226 currently open 028 tickets before 028 releases. Time to move some out. This is my second pass through the "new" and tickets, looking for things to move to 0.2.9.

Trac:
Milestone: Tor: 0.2.8.x-final to Tor: 0.2.9.x-final

We fixed this in #17840 (moved) by making bridge clients:

• prefer IPv6 by default, and
• choose directory and OR addresses using the IP family preferences.

I believe this preserves the existing bridge client behaviour, and fixes directory fetches over IPv6.

Trac:
Status: new to closed
Resolution: N/A to fixed

Tagging these bridge- and PT- items as S-can.

Trac:
Sponsor: N/A to SponsorS-can

Trac:
Keywords: ipv6 bridges deleted, bridges, tor-bridge, ipv6 added

closed

mentioned in issue #17889 (moved)

moved to tpo/core/tor#17854 (closed)