Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #18276

Closed (moved)
Open
Opened Feb 08, 2016 by teor@teor

directory_send_command doesn't check string operation return values

When reviewing directory_send_command() in #18051 (moved), I noticed:

We are not checking the return values of tor_snprintf and strlcpy, I wonder if we should do that.

I wonder if the buffers are large enough:

  • the maximum length of a DNS name is 254 characters, but the buffers are 128 characters
    • the maximum length of an IPv6 address is 48 characters (see TOR_ADDR_BUF_LEN)
    • the maximum length of an IPv4 address is 15 characters
  • the :port adds another 6 characters
  • the http:// adds another 7 characters
To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#18276