Unix socket paths cannot contain spaces

Tor does not handle quotes when parsing *Port configuration lines, and uses only the first space-separated part of the value as the port. It's not possible to have a unix socket in a path containing spaces.

A second related bug: Tor does not error when garbage flags are included at the end of a *Port configuration line.

changed milestone to %Tor: 0.2.9.x-final

added actualpoints::1 component::core tor/tor milestone::Tor: 0.2.9.x-final nickm-deferred-20160905 owner::nickm points::1 priority::medium resolution::implemented review-group-10 reviewer::dgoulet severity::normal status::closed tbb-needs type::defect labels

This might also apply to HiddenServicePort and the control port ADD_ONION command.

Trac:
Points: N/A to 1

I'll take this. The functionality here is likely needed for the future Tor Browser sandboxing efforts. We should also re-examine our control port stuff that deals with paths to ensure sanity.

Trac:
Owner: N/A to yawning
Status: new to assigned

Hi, Yawning! I'm deferring these tickets assigned to you from 0.2.9 to 0.2.???, since you're going to be out for September. But if you wind up wanting to do any of them for 0.2.9 anyway, please feel free to move them back.

(This is my ticket-deferring afternoon)

Trac:
Keywords: N/A deleted, nickm-deferred-20160905 added
Milestone: Tor: 0.2.9.x-final to Tor: 0.2.???

Trac:
Cc: N/A to gk

Trac:
Cc: gk to gk, brade, mcs

Trac:
Keywords: N/A deleted, tbb-needs added

If we could this bug back on track for 0.2.9 that would be neat, although I guess we want to backport a fix for the tor we ship in Tor Browser anyway.

mcs/brade: Do you have a preferred syntax for this fix?

Trac:
Status: assigned to needs_information

You are going to push a socket into the interface intended for a port and try to make it work. (OT: What about #3501 (moved)?)

Replying to gk:

mcs/brade: Do you have a preferred syntax for this fix?

We do not have a syntax in mind; anything that works well and fits with tor's configuration philosophy is good as far as we are concerned. The syntax suggested by nickm in #tor-dev would be fine: SocksPort unix:"/foo/bar/baz quux/socket" IPv6Traffic PreferIPv6Automap

Branch spaces_in_unix_addrs in my public repository may DTRT here. Needs review and acceptance testing.

Trac:
Actualpoints: N/A to 1
Owner: yawning to nickm
Status: needs_information to accepted

Trac:
Status: accepted to needs_review

This change should work for Tor Browser. We need to modify Tor Launcher to use the new quoted syntax for the ControlPort and SocksPort options, and we need to modify Torbutton to correctly parse responses to GETINFO net/listeners/socks. But Kathy and I made enough of a start on the Tor Launcher and Torbutton changes to convince ourselves that this tor patch works.

Resolved #20327 (moved) as duplicate.

Trac:
Cc: gk, brade, mcs to gk, brade, mcs, h9F7Gn

Trac:
Milestone: Tor: 0.2.??? to Tor: 0.2.9.x-final

Trac:
Keywords: N/A deleted, review-group-10 added

This lgtm and works well for SocksPort, HS Port and ControlPort but doesn't work with ControlSocket which takes a path (without unix: prefix though). Do we care about that one not having the possibility to put spaces or quoted string?

Here is an example of it not working:

ControlSocket "/tmp/a control socket"

Apart from that, lgtm;

Trac:
Status: needs_review to needs_information
Reviewer: N/A to dgoulet

I think we now generally prefer the newer FooPort unix:.... syntax to the older FooSocket ... syntax.

Should we then move ControlSocket to the deprecated option list? :)

Trac:
Status: needs_information to merge_ready

I'd take a patch. :)

(Merged!)

Trac:
Resolution: N/A to implemented
Status: merge_ready to closed

closed

changed time estimate to 8h

added 8h of time spent

mentioned in issue #20111 (moved)

mentioned in issue #20145 (moved)

mentioned in issue #20210 (moved)

mentioned in issue #20250 (moved)

mentioned in issue #20327 (moved)

mentioned in issue #20627 (moved)

moved to tpo/core/tor#18753 (closed)