Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #19127

Closed (moved)
(moved)
Open
Created May 19, 2016 by teor@teor

Don't crash authorities with more than 254 shared random reveals

Rather than asserting that a tor network never has more than 253 authorities, we could instead log when we truncate the number of reveals in the shared random hash.

As a consequential change, we should do this truncation as late as possible, so that the value assigned to srv->num_reveals is not truncated.

In any case, tor_assert(reveal_num < UINT8_MAX); is unnecessarily strict, it can be tor_assert(reveal_num <= UINT8_MAX);.

Please see my branch sr-no-crash on https://github.com/teor2345/tor.git for fixes to these issues.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking