GitLab

In dgoulet's srv-testing-2, git 0234595:

The original patch to sr_parse_commit was:

-  version = (uint32_t) tor_parse_long(value, 10, 1, UINT32_MAX, NULL, NULL);
+  version = (uint32_t) tor_parse_ulong(value, 10, 1, UINT32_MAX, NULL, NULL);

Since this is a regression, it's worth noting that the unit test shared-random/sr_commit tests version parsing as part of commit parsing. It will fail on 32 bit platforms if we make this mistake again. (I can't see any way to make it fail on 64-bit platforms - using fixed-size integers with a function that takes platform-dependent-size integers is inherently error-prone, see #19063 (moved).)

Also, since this is a regression, can you please make sure that no other patches from the last few comments in #16943 (moved) were dropped?