Skip to content
Snippets Groups Projects
Closed (moved) node_get_by_nickname() fails to give warning on unique-but-unnamed node.
  • View options
  • node_get_by_nickname() fails to give warning on unique-but-unnamed node.

  • View options
  • Closed (moved) Issue created by Nick Mathewson

    There are two checks in node_get_by_nickname for listing an unnamed router by name. One checks for (smartlist_len(matches)>1 && warn_if_unnamed), whereas the other one also checks for (smartlist_len(matches)>1 && warn_if_unnamed). Whoops.

    The impact is that if there is one match, no warning will be produced, even though it arguably should (now that Naming is no longer a thing).

    Found by GCC6 with -Wduplicated-cond as part of #19180 (moved).

    Linked items ... 0

  • Activity

    • All activity
    • Comments only
    • History only
    • Newest first
    • Oldest first
    Loading Loading Loading Loading Loading Loading Loading Loading Loading Loading