Skip to content
GitLab
Projects Groups Topics Snippets
  • /
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #19566
Closed (moved) (moved)
Open
Issue created Jul 04, 2016 by David Goulet@dgoulet🐼

SR: Use BUG() instead of tor_assert() when we can

Example:

tor_assert(sr_state_get_phase() == SR_PHASE_REVEAL);

Should be replaced by:

if (BUG(sr_state_get_phase() != SR_PHASE_REVEAL))
  return;

The idea is to not kill the dirauth if this happens but still scream very loudly. Few other places in the SR subsystem can be found.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking