Skip to content
Snippets Groups Projects

Integrate selfrando into the alpha Linux 64bit builds

    • Closed (moved) Issue created by Georg Koppen @gk

    We are currently shipping selfrando in our hardened builds. We should include it into our regular alphas to give it a wider test audience.

    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    • No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    • Georg Koppen added GeorgKoppen201704 TorBrowserTeam201705R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal sponsor::4 status::closed tbb-security type::task labels

      added GeorgKoppen201704 TorBrowserTeam201705R component::applications/tor browser owner::tbb-team priority::medium resolution::fixed severity::normal sponsor::4 status::closed tbb-security type::task labels

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Trac:
      Keywords: N/A deleted, GeorgKoppen201611 added

    • Y
      Yawning Angel @yawning ·

      Trac:
      Cc: N/A to yawning

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Trac:
      Summary: Integrate selfrando into the alpha Linux builds to Integrate selfrando into the alpha Linux 64bit builds

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Trying to compile selfrando for 32bit system crashes with

      g++ -o sconsRelease/x86/gcc/LinuxSymproc/ObjectFileParser.o -c -std=c++11 -include /home/debian/build/elfutils-0.160/libelf/elf.h -I /home/debian/install/elfutils/include -fno-reorder-functions -O2 -fno-omit-frame-pointer -g -Wl,-z,noexecstack -m32 -DRANDOLIB_ARCH=x86 -DRANDOLIB_ARCH_SIZE=32 -DRANDOLIB_IS_X86=1 -IsconsRelease/x86/gcc/LinuxSymproc -ILinuxSymproc LinuxSymproc/ObjectFileParser.cpp
LinuxSymproc/ObjectFileParser.cpp: In member function 'void ExecFileParser::add_txtrp_section(const std::vector<ObjectFileParser::Section>&, const ObjectFileParser::NonExecutableRelocations&)':
LinuxSymproc/ObjectFileParser.cpp:383:78: error: no matching function for call to 'max(long unsigned int&, ELFIO::Elf64_Addr)'
         p = std::max(p, segm->get_virtual_address() + segm->get_memory_size());
                                                                              ^
In file included from /home/debian/install/gcc/include/c++/5.1.0/algorithm:61:0,
                 from LinuxSymproc/ObjectFileParser.cpp:9:
/home/debian/install/gcc/include/c++/5.1.0/bits/stl_algobase.h:219:5: note: candidate: template<class _Tp> const _Tp& std::max(const _Tp&, const _Tp&)
     max(const _Tp& __a, const _Tp& __b)
     ^
/home/debian/install/gcc/include/c++/5.1.0/bits/stl_algobase.h:219:5: note:   template argument deduction/substitution failed:
LinuxSymproc/ObjectFileParser.cpp:383:78: note:   deduced conflicting types for parameter 'const _Tp' ('long unsigned int' and 'ELFIO::Elf64_Addr {aka long long unsigned int}')
         p = std::max(p, segm->get_virtual_address() + segm->get_memory_size());

      After talking to the selfrando devs it turns out the 32bit mode never really got finished properly. Thus we integrate it only for 64bit bundles for now. I've filed #20848 (moved) for the 32bit part.

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Moving my tickets

      Trac:
      Keywords: GeorgKoppen201611 deleted, GeorgKoppen201612 added

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Moving tickets to December.

      Trac:
      Keywords: TorBrowserTeam201611 deleted, TorBrowserTeam201612 added

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Hm it seems 64bit builds outside of our hardened context break as well:

      + exec c++ -o webapprt-stub -Wall -Wempty-body -Woverloaded-virtual -Wsign-compare -Wwrite-strings -Wno-invalid-offsetof -Wcast-align -frandom-seed=tor -fno-exceptions -fno-strict-aliasing -fno-rtti -fno-exceptions -fno-math-errno -std=gnu++0x -pipe -DNDEBUG -DTRIMMED -g -freorder-blocks -Os -fomit-frame-pointer /home/debian/build/tor-browser/obj-x86_64-unknown-linux-gnu/webapprt/gtk/tmpZ7SNKK.list -lpthread -Wl,-z,noexecstack -Wl,-z,text -Wl,--build-id -rdynamic -Wl,-rpath-link,/home/debian/build/tor-browser/obj-x86_64-unknown-linux-gnu/dist/bin -Wl,-rpath-link,NONE/lib ../../xpcom/glue/standalone/libxpcomglue.a -ldl -lrt -lgtk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lfreetype -lfontconfig -lgdk-x11-2.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lpango-1.0 -lcairo -lgobject-2.0 -lglib-2.0 -B /home/debian/build/selfrando/Tools/TorBrowser/tc-wrapper
+ /home/debian/install/binutils/bin/ld.gold --section-start .interp=0x400800 -dn /home/debian/install/selfrando/randoentry.o /home/debian/install/selfrando/sr_begin.o /home/debian/install/selfrando/libselfrando.a /home/debian/install/selfrando/sr_end.o -dy -plugin /home/debian/install/gcc/libexec/gcc/x86_64-unknown-linux-gnu/5.1.0/liblto_plugin.so -plugin-opt=/home/debian/install/gcc/libexec/gcc/x86_64-unknown-linux-gnu/5.1.0/lto-wrapper -plugin-opt=-fresolution=/tmp/ccwYIH0z.res -plugin-opt=-pass-through=-lgcc_s -plugin-opt=-pass-through=-lgcc -plugin-opt=-pass-through=-lc -plugin-opt=-pass-through=-lgcc_s -plugin-opt=-pass-through=-lgcc --eh-frame-hdr -m elf_x86_64 -export-dynamic -dynamic-linker /lib64/ld-linux-x86-64.so.2 -pie -o webapprt-stub /usr/lib/x86_64-linux-gnu/Scrt1.o /usr/lib/x86_64-linux-gnu/crti.o /home/debian/install/gcc/lib/gcc/x86_64-unknown-linux-gnu/5.1.0/crtbeginS.o -L/home/debian/build/selfrando/Tools/TorBrowser/tc-wrapper -L/home/debian/install/gcc/lib/gcc/x86_64-unknown-linux-gnu/5.1.0 -L/home/debian/install/gcc/lib/gcc/x86_64-unknown-linux-gnu/5.1.0/../../../../lib64 -L/lib/x86_64-linux-gnu -L/lib/../lib64 -L/usr/lib/x86_64-linux-gnu -L/home/debian/install/gcc/lib/gcc/x86_64-unknown-linux-gnu/5.1.0/../../.. /home/debian/build/tor-browser/obj-x86_64-unknown-linux-gnu/webapprt/gtk/tmpZ7SNKK.list -lpthread -z noexecstack -z text --build-id -rpath-link /home/debian/build/tor-browser/obj-x86_64-unknown-linux-gnu/dist/bin -rpath-link NONE/lib ../../xpcom/glue/standalone/libxpcomglue.a -ldl -lrt -lgtk-x11-2.0 -latk-1.0 -lgio-2.0 -lpangoft2-1.0 -lfreetype -lfontconfig -lgdk-x11-2.0 -lpangocairo-1.0 -lgdk_pixbuf-2.0 -lpango-1.0 -lcairo -lgobject-2.0 -lglib-2.0 -lstdc++ -lm -lgcc_s -lgcc -lc -lgcc_s -lgcc /home/debian/install/gcc/lib/gcc/x86_64-unknown-linux-gnu/5.1.0/crtendS.o /usr/lib/x86_64-linux-gnu/crtn.o --build-id=none -Map webapprt-stub.map ./padding.j0MrJ45JzmDsL3m.o
+ /home/debian/install/selfrando/SymProc webapprt-stub webapprt-stub.map -ffunction-sections
Unknown type 20 (file '/home/debian/build/tor-browser/obj-x86_64-unknown-linux-gnu/webapprt/gtk/../../memory/mozjemalloc/jemalloc.o', section: .rela.text.choose_arena, offset: 4, relo index: 0/19)
collect2: error: ld returned 13 exit status
make[5]: *** [webapprt-stub] Error 1
    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Moving our tickets to January 2017

      Trac:
      Keywords: TorBrowserTeam201612 deleted, TorBrowserTeam201701 added

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Trac:
      Keywords: GeorgKoppen201612 deleted, GeorgKoppen201701 added

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Moving our tickets to Feb 2017.

      Trac:
      Keywords: TorBrowserTeam201701 deleted, TorBrowserTeam201702 added

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      This is Sponsor4 work

      Trac:
      Sponsor: N/A to Sponsor4

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Moving my tickets as well

      Trac:
      Keywords: GeorgKoppen201701 deleted, GeorgKoppen201702 added

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      bug_20683_v4 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_20683_v4&id=74bc959b60d4ebb04179a87a113fbb5254d9d3fa) in my public repo has a patch for review. It uses TrapLinker now under the hood which fixes the NSS AES incompatibility as well and improves stability in general. The relevant selfrando and elfutils commits/tags are in the nightly versions file. I'll update the alpha one with proper tags once we had the code baking in our nightlies for a while and nothing exploded.

      Note: This patch makes use of our own gcc/binutils for the remaining components in the gitian-utils descriptor (a thing I wanted to have for quite a while now).

      Trac:
      Status: new to needs_review
      Keywords: TorBrowserTeam201702 deleted, TorBrowserTeam201703R added

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Moving my tickets.

      Trac:
      Keywords: GeorgKoppen201702 deleted, GeorgKoppen201703 added

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Moving review tickets to April.

      Trac:
      Keywords: TorBrowserTeam201703R deleted, TorBrowserTeam201704R added

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Trac:
      Status: needs_review to needs_revision
      Keywords: TorBrowserTeam201704R, GeorgKoppen201703 deleted, GeorgKoppen201704, TorBrowserTeam201704 added

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Rebased and with a small fixup: bug_20683_v5 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_20683_v5&id=353c304ac5c9d7fee61f6f47ae0f5967eb40f005).

      Trac:
      Keywords: TorBrowserTeam201704 deleted, TorBrowserTeam201704R added
      Status: needs_revision to needs_review

    • boklm
      boklm @boklm ·

      Replying to gk:

      Rebased and with a small fixup: bug_20683_v5 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_20683_v5&id=353c304ac5c9d7fee61f6f47ae0f5967eb40f005).

      It looks like the gitian/gpg/ELFUTILS.gpg file is missing in this commit (but was present in v4). Except for this, the changes look good.

    • Georg Koppen
      Georg Koppen @gk ·
      Author

      Oops, thanks for catching this. Fixed with commit 0ea68f848f54aaeceeeed22dc1496d3723cbe128 which landed on master.

      Trac:
      Status: needs_review to closed
      Resolution: N/A to fixed

    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    • Loading
    Please register or sign in to reply