Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #2135

Closed
Open
Opened Oct 29, 2010 by Erinn Clark@erinn

Generalize Vidalia's configuration for Firefox

Once upon a time there was a single Tor Browser Bundle for Windows, but now we also support OS X and Linux, and Vidalia has to be patched in order to handle TBBs that aren't Windows. It has some hardcoded paths that were originally setup in order to better handle Firefox Portable's directory structure, but these don't apply to Linux or OS X, and probably won't apply to Windows either when I start building Firefox for all of the platforms. (I currently do this for OS X and x86_64.)

You can see how this is handled by default in src/vidalia/MainWindow.cpp at: 590: MainWindow::launchBrowserFromDirectory()

In my ideal world, I would just give the full path in vidalia.conf without having to patch that file or create strange directory structures in order to obey it.

I've also attached a diff between the default MainWindow.cpp and the patched version used on OS X.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Vidalia: 0.3.x
Milestone
Vidalia: 0.3.x
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#2135