Unify Windows and Unix API for tor_read_all_handle() in util.c

While working on #21654 (moved) I noticed that we have some different code paths that depends upon whether we're running on Windows or not where it would be trivial to turn them into a single code path.

I do not have access to a Windows machine right now, so it would be useful if someone could help test the patch(es).

changed milestone to %Tor: unspecified

added 034-removed-20180328 034-triage-20180328 component::core tor/tor milestone::Tor: unspecified owner::ahf priority::low resolution::implemented severity::normal status::closed type::enhancement labels

Trac:
Owner: N/A to ahf
Status: new to accepted

I've added an untested patch to https://gitlab.com/ahf/tor/commits/bugs/21678 - it would be useful to get someone with a Windows machine to try it out. Otherwise, I'll try to get a Windows environment up and running and try it out there.

I'm not marking this issue as needs_review since the code is still untested.

See also #11660 (moved)

Trac:
Parent: #21654 (moved) to N/A

Postponing this to 0.3.2.

Trac:
Milestone: Tor: 0.3.1.x-final to Tor: 0.3.2.x-final

See #22380 (moved) if we do this.

Trac:
Milestone: Tor: 0.3.2.x-final to Tor: 0.3.3.x-final

Trac:
Milestone: Tor: 0.3.3.x-final to Tor: 0.3.4.x-final

Trac:
Keywords: N/A deleted, 034-triage-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

Trac:
Keywords: N/A deleted, 034-removed-20180328 added

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Trac:
Milestone: Tor: 0.3.4.x-final to Tor: unspecified

These functions was removed as part of the new process subsystem in 0.4.0.

Trac:
Status: accepted to closed
Resolution: N/A to implemented

closed

moved to tpo/core/tor#21678 (closed)