TBB 7.0a3 doesn't properly show HTTPS warning

When visiting a website with a "bad" certificate the browser usually shows a warning. With TBB7.0a3 I get a basically white window with a back back and an advanced button which does not work (see screenshot). I could reproduce this with several sites (https://pads.ccc.de https://www.geonames.org etc.).

added GeorgKoppen201704 TorBrowserTeam201704R component::applications/tor browser ff52-esr owner::tbb-team priority::medium resolution::fixed severity::normal status::closed tbb-usability type::defect labels

Trac:

Screenshot

It works better for me. I'm on Linux 64-bit English.

Which platform are you on? Looks like you're using the Deutsch version?

It is the german/deutsch 64 Bit version

Well, the problem is similar to the one in #21887 (moved): on higher security levels there is no JavaScript whitelisted for about:certerror pages. It seems we need that now. See: bug_22025 (https://gitweb.torproject.org/user/gk/tor-browser-bundle.git/commit/?h=bug_22025&id=59c8d12dad8ca01ddf8e21634448b0edb1c761f9) for a fix. qbi: If you look at the patch, you can fix that issue locally by adding about:certerror to the respective keys in your about:config.

Trac:
Keywords: N/A deleted, tbb-usability, GeorgKoppen201704, TorBrowserTeam201704R, ff52-esr added
Status: new to needs_review

I did it and the certerror page works as expected. Thanks.

r=mcs This patch looks fine to me.

It would be great if there was a way for us to avoid overriding a default NoScript pref (and therefore to avoid this kind of problem in the future). But I guess we would need support in NoScript for one or more prefs that allow us to add to the list instead of replacing it.

Replying to mcs:

r=mcs This patch looks fine to me.

That's commit bf51814f82a93a2f26322a3eea7e31ef061edc6d on master now, thanks.

It would be great if there was a way for us to avoid overriding a default NoScript pref (and therefore to avoid this kind of problem in the future). But I guess we would need support in NoScript for one or more prefs that allow us to add to the list instead of replacing it.

Yes. So far there is no really good solution to this problem.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

Maybe, ask Maone?

closed

moved to tpo/applications/tor-browser#22025 (closed)