Consensus health is concerned about missing reveal values but it shouldn't
Hello,
Sebastian the other day let me know that consensus health marks missing SRV reveal values as red, even when we are in commit phase and there shouldn't be any reveal values there.
e.g.:
[V:1 A:sha3-256 C:AAAAAFj9QADRCL8xJjqrEGCYLDD8rirah1ekzwwFtzwI1rbNUbr35g==(Empty)],
[V:1 A:sha3-256 C:AAAAAFj9QACpdT+YSqMfmqydd0pifsVDh6RXjFdUHjWFxDrJFOfKGQ==(Empty)],
[V:1 A:sha3-256 C:AAAAAFj9QACfd6bmG5brC5zEZT0OxA/q9b0pnTlWAkO45i0oaRah0Q==(Empty)],
[V:1 A:sha3-256 C:AAAAAFj9QAA9PtA2l5UnnKvp+t9NA0FQlLPe/RobysQU8Is6Zskb6w==(Empty)],
[V:1 A:sha3-256 C:AAAAAFj9QAB9yqvzx3kBe9Pm3dfOPDLsRQVhgLFvfFZ6FWil7gAPoQ==(Empty)],
It's perfectly normal that there are no reveal values, because from 00:00 UTC to 12:00 UTC we have the commit phase where there are no reveals at all. From 12:00 UTC to 00:00 UTC there should be reveal values.
I can see two fixes here:
a) Easy fix: Stop having (Empty)
with red letters to reduce reader anxiety.
b) Involved fix: Check whether the vote is in commit phase or reveal phase (using valid-after
) and only put (Empty)
there when we are in reveal phase and there should be a reveal value there.