Document which interface is used for DNS requests in the context of OutboundBindAddressOR/Exit

In #17975 (moved) two new options have been added:

• OutboundBindAddressOR
• OutboundBindAddressExit

The manual page makes no clear statement which interface is used for DNS traffic.

https://trac.torproject.org/projects/tor/ticket/17975#comment:13 hints towards OutboundBindAddressOR, but users should not be required to search the bugtracker find out about that.

changed milestone to %Tor: 0.3.3.x-final

added component::core tor/tor easy manpage milestone::Tor: 0.3.3.x-final points::.5 priority::medium resolution::fixed review-group-28 severity::normal status::closed tor-doc type::defect version::tor 0.3.0.6 labels

Trac:
Version: N/A to Tor: 0.3.0.6

The answer is:

• OutboundBindAddressOR is used for OR and directory (DirPort) connections:
  • directory_initiate_request()
  • connection_or_connect()
• OutboundBindAddressExit is used for Exit connections:
  • connection_exit_connect()
• an unspecified address (typically, the OS routing table) is used for all other connections:
  • evdns_base_resolve_*()
  • are there any other connection types?

Trac:
Keywords: N/A deleted, easy doc added

Missing milestone.

Trac:
Milestone: N/A to Tor: unspecified

Trac:
Keywords: easy doc deleted, easy tor-doc manpage added
Points: N/A to .5

Trac:
Username: aruna1234

0006-Doc-edited-about-DNS-Requests.patch

Trac:
Username: aruna1234

Document edited as OutboundBindAddressExit() resposible for DNS requests.

Trac:
Username: aruna1234

version.This

Please change that to,

version. This

Trac:
Status: new to needs_revision

Trac:
Username: aruna1234

0007-Doc-edited-about-DNS-Requests.patch

Trac:
Username: aruna1234

Trac:
Status: needs_revision to needs_review

Trac:
Milestone: Tor: unspecified to Tor: 0.3.3.x-final

Thanks for this patch, but the sentence you wrote is not correct.

See: https://trac.torproject.org/projects/tor/ticket/22145#comment:2

Instead, we should explain under OutboundBindAddress that it does not apply to DNS requests.

Trac:
Status: needs_review to needs_revision

Trac:
Username: aruna1234

0008-Doc-edited-specifying-DNS-requests.patch

Trac:
Username: aruna1234

Doc edited by mentioning in OutboundBindAddress that it is not used for DNS Requests.

Trac:
Username: aruna1234

Thanks! This looks good. We don't need a changes file, because it's a documentation-only change,

We will need to squash all the patch files attacked to this ticket to get the final commit,

In future, for small commits like this, can you put all the changes in each patch file? That makes it easier for us to squash.

Or, you can tell us a branch on a public git repository, like github,com. Branches are also easy to squash.

Trac:
Status: needs_revision to merge_ready

Please see my branch bug22145_032, which squashes the patches in this ticket.

Replying to teor:

Thanks! This looks good. We don't need a changes file, because it's a documentation-only change,

We will need to squash all the patch files attacked to this ticket to get the final commit,

In future, for small commits like this, can you put all the changes in each patch file? That makes it easier for us to squash.

Or, you can tell us a branch on a public git repository, like github,com. Branches are also easy to squash.

Thanks! Will take care from next time.

Trac:
Username: aruna1234

Trac:
Keywords: easy tor-doc manpage deleted, review-group-28, tor-doc, easy, manpage added

Merged, and added a changes file.

Trac:
Resolution: N/A to fixed
Status: merge_ready to closed

closed

changed time estimate to 4h

mentioned in issue #24703 (moved)

moved to tpo/core/tor#22145 (closed)