Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #22315

Closed (moved)
Open
Opened May 20, 2017 by cypherpunks@cypherpunks

Make use of interceptor to protect memory on Windows (spin-off from #12426)

add EnableLowFragmentationHeap() modified from ​https://dxr.mozilla.org/mozilla-esr24/source/ipc/chromium/src/base/process_util_win.cc#867 It was an old approach from Google that couldn't be applied, because it was single-threaded and led to: https://blogs.msdn.microsoft.com/oldnewthing/20110701-00/?p=10273/ So that they added just https://chromium.googlesource.com/chromium/src/+/e4adea20236d1cee76f0c61798b1613e07a7f4c1/chrome/app/chrome_exe_main_win.cc#113 from a well-known approach http://microsoft.public.vsnet.general.narkive.com/vkWRTQaL/low-fragmentation-heap, but with that test https://chromium.googlesource.com/chromium/src/+/95b42e2745a2380a16112a059bd0e842d81f0c0a/base/process_util_unittest.cc#377 So you can add Chromium's solution as fast and easy fix (as in #12426 (moved)), but for the default heap only.

A more general approach is to use an interceptor for LFH, bottom-up ASLR and other mitigations on every relevant memory allocation: https://github.com/promised-lu/MemoryProtection/blob/master/MemoryProtection/MemoryProtection.cxx

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#22315