Rename channelpadding.c's CHANNEL_IS_CLIENT to avoid confusion

There is already a channel_is_client() function in channel.[ch], with different arguments and semantics.

And while we're doing that, we should make the newly renamed CHANNEL_IS_CLIENT() call channel.h's channel_is_client(), because it's the right abstraction to use.

We could survive releasing 0.3.1 without this fix, because it's not a bug (yet).

changed milestone to %Tor: unspecified

added 031-deferrable 033-removed-20180320 033-triage-20180320 component::core tor/tor disaster-waiting-to-happen milestone::Tor: unspecified parent::24905 points::0.1 priority::medium severity::normal status::new technical-debt type::defect version::tor 0.3.1.1-alpha labels

Trac:
Cc: N/A to mikeperry

Trac:
Owner: N/A to mikeperry
Status: new to assigned

I ran into a bunch of cases where channel->is_client flag was not updated, was incorrect, or disagreed with the definition I needed (in cases like bridges). How are we on ensuring that flag always has the same meaning as the macro checks for?

Replying to mikeperry:

I ran into a bunch of cases where channel->is_client flag was not updated, was incorrect, or disagreed with the definition I needed (in cases like bridges).

Is this before or after the fix in #21406 (moved) in 0.3.1.1-alpha? If there are any of these cases left, please list these cases in a different ticket in 0.3.1.

How are we on ensuring that flag always has the same meaning as the macro checks for?

The macro and the flag have a different meaning, so they should have different names.

The flag means:

/** True iff we have decided that the other end of this connection
   * is a client or bridge relay.  Connections with this flag set should never
   * be used to satisfy an EXTEND request. */

https://gitweb.torproject.org/tor.git/tree/src/or/channel.h#n302 We will clarify this by renaming the function in #22090 (moved).

The macro means:

/**
 * This macro tells us if either end of the channel is connected to a client.
 * (If we're not a server, we're definitely a client. If the channel thinks
 *  its a client, use that. Then finally verify in the consensus).
 */

https://gitweb.torproject.org/tor.git/tree/src/or/channelpadding.c#n63 Renaming the macro is what this ticket is for.

Trac:
Milestone: Tor: 0.3.1.x-final to Tor: 0.3.3.x-final

Trac:
Parent: N/A to #24905 (moved)

Marking all tickets reached by current round of 033 triage.

Trac:
Keywords: N/A deleted, 033-triage-20180320 added

Mark all not-already-included tickets as pending review for removal from 0.3.3 milestone.

Trac:
Keywords: N/A deleted, 033-removed-20180320 added

These tickets were marked as removed, and nobody has said that they can fix them. Let's remember to look at 033-removed-20180320 as we re-evaluate our triage process, to see whether we're triaging out unnecessarily, and to evaluate whether we're deferring anything unnecessarily. But for now, we can't do these: we need to fix the 033-must stuff now.

Trac:
Milestone: Tor: 0.3.3.x-final to Tor: unspecified

Trac:
Owner: mikeperry to N/A

Change tickets that are assigned to nobody to "new".

Trac:
Status: assigned to new

changed time estimate to 48m

mentioned in issue #24905 (moved)

moved to tpo/core/tor#22717

mentioned in issue tpo/core/tor#24905 (closed)