Warnings from isnan, isinfinite, signbit on mingw
We're seeing these on jenkins. They're somewhat annoying. I have a fix. Making this ticket for tracking purposes.
11:32:49 In file included from src/common/util.c:44:0:
11:32:49 src/common/util.c: In function 'clamp_double_to_int64':
11:32:49 src/common/util.c:5602:13: error: conversion to 'float' from 'double' may alter its value [-Werror=float-conversion]
11:32:49 if (isnan(number)) {
11:32:49 ^
11:32:49 src/common/util.c:5620:16: error: conversion to 'float' from 'double' may alter its value [-Werror=float-conversion]
11:32:49 if (isfinite(number) && exponent <= 63) {
11:32:49 ^
11:32:49 src/common/util.c:5625:18: error: conversion to 'float' from 'double' may alter its value [-Werror=float-conversion]
11:32:49 return signbit(number) ? INT64_MIN : INT64_MAX;
11:32:49 ^
11:32:50 cc1: all warnings being treated as errors