Build go and go pluggable transports for Windows 64

We need to build go, and go pluggable transports (meek and obfs4) for Windows 64.

added TorBrowserTeam201711R component::applications/tor browser owner::boklm parent::20636 priority::medium resolution::fixed severity::normal status::closed tbb-rbm type::task labels

This patch is fixing the build of go for Windows 64: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_20636_v6&id=bdd72adb05bdec2d5d05f2bff3cb3d6899f1e9be

Using this patch I am able to build meek and obfs4 for Windows 64.

I am not setting this ticket as needs_review yet as we probably want to finish #23228 (moved) first before merging this one.

(Could you also add GO386=387 to fix 32-bit builds?)

Replying to cypherpunks:

(Could you also add GO386=387 to fix 32-bit builds?) Do you have more details about the problem it should fix?

If I understand the documentation from https://golang.org/doc/install/source correctly, this option is either sse2 or 387 for non-sse2 support. However we don't support not SSE2 capable Windows machines anymore. Or do you want that for Linux builds?

For both. For consistency and determinism.

For what it's worth, I do not support non-SSE2 obfs4proxy so if there are weird bugs, I will point and laugh at you.

Replying to yawning:

For what it's worth, I do not support non-SSE2 obfs4proxy so if there are weird bugs, I will point and laugh at you. It worked a year or so ago, thus if you added weird bugs after that, "I will point and laugh at you."

Trac:
Cc: tbb-team to tbb-team, dcf

Items for October 2017

Trac:
Keywords: TorBrowserTeam201709 deleted, TorBrowserTeam201710 added

The branch bug_23456 in my git repo has a patch for review: https://gitweb.torproject.org/user/boklm/tor-browser-build.git/commit/?h=bug_23456&id=83407b9eee94991a7c8c13dbcaf35693f0e7c9e9

(this branch also contains the patch for #10026 (closed), so it should be cherry-picked if merged before #10026 (closed))

Trac:
Keywords: TorBrowserTeam201710 deleted, TorBrowserTeam201711R added
Status: assigned to needs_review

Looks good. This is commit 83407b9eee94991a7c8c13dbcaf35693f0e7c9e9 on master now.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#23456 (closed)