rbm should download again an input file if it is not matching the expected sha256sum

When an input file of type URL is already present in the out/ directory, we use it without downloading it again. This is a problem in the case of #23396 (moved) where we want to be able to use a new version of a file without changing its filename.

To solve this, rbm should download again a file when the existing file does not match the expected sha256sum.

added TorBrowserTeam201709R component::applications/tor browser owner::boklm priority::medium resolution::fixed severity::normal status::closed tbb-rbm type::task labels

I created a branch bug_23557_v2 on my oniongit rbm repo, with a patch to fix that: https://oniongit.eu/boklm/rbm/commits/bug_23557_v2

Trac:
Keywords: TorBrowserTeam201709 deleted, TorBrowserTeam201709R added
Status: assigned to needs_review

Hm, how is that supposed to work? I did the following:

1. Added

-  - URL: https://people.torproject.org/~mikeperry/mirrors/sources/msvcr100.dll
-    sha256sum: 1221a09484964a6f38af5e34ee292b9afefccb3dc6e55435fd3aaf7c235d9067
+  - URL: https://people.torproject.org/~gk/mirrors/sources/msvcr100.dll
+    sha256sum: 8793353461826fbd48f25ea8b835be204b758ce7510db2af631b28850355bd18

to my tor-browser-build instance. 2) I verified that the sha256sum value is "1221a09484964a6f38af5e34ee292b9afefccb3dc6e55435fd3aaf7c235d9067" for the msvcr100.dll file I have in out/firefox 3) I cloned rbm and applied the patch in this ticket 4) I did /path/to/cloned_rbm/rbm fetch in my tor-browser-build directory 5) I verified that the sha256sum value is still the same as in 2)

If I am doing something wrong, let me know and just put that ticket back in needs_review.

Trac:
Status: needs_review to needs_revision
Keywords: TorBrowserTeam201709R deleted, TorBrowserTeam201709 added

Replying to gk:

4. I did /path/to/cloned_rbm/rbm fetch in my tor-browser-build directory

The fetch command is only used for fetching new commits from git/hg, but it does not fetch the other types of files. To do that you have to start a new build.

So you need to run something like:

/path/to/cloned_rbm/rbm build release --target testbuild --target torbrowser-windows-i686

Trac:
Status: needs_revision to needs_review

To test the patch on a computer where doing a full build would take too much time, I created the file projects/bug_23557/config with this content:

# vim: filetype=yaml sw=2
version: 1

build: |
  #!/bin/sh
  echo ok
input_files:
  - URL: https://people.torproject.org/~boklm/tmp/msvcr100.dll
    sha256sum: 8793353461826fbd48f25ea8b835be204b758ce7510db2af631b28850355bd18

Then I ran:

/path/to/rbm build bug_23557

Checked the hash of the file in out/bug_23557/msvcr100.dll.

Updated the URL and hash of msvcr100.dll in projects/bug_23557/config, then ran again:

/path/to/rbm build bug_23557

Then checked that out/bug_23557/msvcr100.dll was changed.

Okay, added a discussion item.

Trac:
Keywords: TorBrowserTeam201709 deleted, TorBrowserTeam201709R added

Looks good. Applied to master (commit 236fcaac2012531330f21d2e9cce49a534a03b60) and I pushed a tor-browser-build commit (a27578e6fd0daf2f2133c6e179d968417bc3547d) to pick up the rbm changes.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-browser#23557 (closed)