Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #23993

Closed (moved)
Open
Opened Oct 25, 2017 by David Goulet@dgoulet🐋

sched: Refactor and fix interactions between channel and scheduler

This is a top level ticket for all the things we need to address in the channel subsystem and scheduler.

Channels interact with the scheduler using a few entry points and assumptions provided by the circuit and channel subsystem. However, it turns out that the channel abstraction is often violated from the connection subsystem with channel_t and channeltls_t objects.

We also have too many cells queues that goes from connection inbuf to circuit queue to channel queue to connection outbuf. But #23709 (moved) showed us that the channel queues aren't quite working as intended.

Furthermore, we put scheduler state data in the channel_t object that are actually only relevant to the Vanilla scheduler but not to the other types (KIST and KISTLite for now).

Along with pastly, we've discussed changes to simplify the scheduler interface, to make scheduler data stored in a channel tied to a scheduler type and make some changes to improve the channel subsystem.

The child tickets address all of the above (and maybe more) in order to have a leaner channel subsystem that actually provides properties and correct assumptions to the scheduler.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#23993