Skip to content

GitLab

  • Menu
Projects Groups Snippets
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
  • Trac Trac
  • Project information
    • Project information
    • Activity
    • Labels
    • Members
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Service Desk
    • Milestones
  • Monitor
    • Monitor
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value stream
  • Wiki
    • Wiki
  • Activity
  • Create a new issue
  • Issue Boards
Collapse sidebar
  • Legacy
  • TracTrac
  • Issues
  • #2412

Closed
Open
Created Jan 19, 2011 by Damian Johnson@atagar

TorCtl isn't joining on _thread

Very simple bug: the launch_thread function of torctl spawns two threads (self._thread and self._eventThread), but its close function only joins on self._eventThread [1]. The result is that the _thread lives a little longer (you can confirm this by checking threading.enumerate() after calling close): 1/19/2011 09:18:49 [INFO] [<_MainThread(MainThread, started -1216911680)>, <Thread(TorLoop, started daemon -1217868944)>]

This should be a trivial fix, though unfortunately it isn't the cause of the concurrency troubles I'm trying to track down. :(

-Damian

[1] https://gitweb.torproject.org/pytorctl.git/blob/HEAD:/TorCtl.py#l636

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Time tracking