bootstrap error message sometimes lost

If another STATUS_CLIENT message is received on the control port while Tor Launcher is displaying an error, the error message is replaced with a status message. This was reported in ticket:24367#comment:15.

To avoid this problem, we plan to ignore STATUS_CLIENT messages when Tor Launcher is in "error display" mode.

added TorBrowserTeam201712R component::applications/tor launcher owner::brade priority::medium resolution::fixed severity::normal sponsor::4 status::closed type::defect labels

Trac:
tor-and-tor-launcher-log.txt

The attachment I just added includes both tor and Tor Launcher logging. Notice that a STATUS_CLIENT NOTICE message is received after the STATUS_CLIENT WARN message. We are working on a patch for Tor Launcher.

Here is a fix: https://gitweb.torproject.org/user/brade/tor-launcher.git/commit/?h=bug24428-01&id=2cc63c03e1c67e2db71e581db1f6ca17cb75bcd1

Trac:
Status: new to needs_review
Keywords: TorBrowserTeam201711 deleted, TorBrowserTeam201711R added

Replying to brade:

Here is a fix: https://gitweb.torproject.org/user/brade/tor-launcher.git/commit/?h=bug24428-01&id=2cc63c03e1c67e2db71e581db1f6ca17cb75bcd1

Thanks, do you have some easy STR for me to check what happens without the patch and make sure your patch actually fixes this bug?

Trac:
Status: needs_review to needs_information

Moving review tickets over to December

Trac:
Keywords: TorBrowserTeam201711R deleted, TorBrowserTeam201712R added

Replying to gk:

Thanks, do you have some easy STR for me to check what happens without the patch and make sure your patch actually fixes this bug?

It is a little tricky to reproduce because the bug is timing-dependent, so you may need to try several times. And note that Kathy and I only reproduced it on OSX (but I think catalyst saw it on Linux). That said, here are some STR:

1. Start with a clean Tor Browser that uses the new Tor Launcher UI, e.g., 7.5a8.
2. Set you system clock forward; Kathy and I used 24 or 25 hours but catalyst saw the bug with a +3.5 hour offset.
3. Start Tor Browser and click Connect.

If the bug occurs, you will see a stalled progress bar after a while with a bold progress message such as "Loading relay information." The bold font is an indication that an error message was displayed and then replaced with a regular bootstrap progress message.

Trac:
Status: needs_information to needs_review

Looks good. Applied to master as commit c4f55f9f2c29caad1270ece1bc723d22d0996f3e.

Trac:
Resolution: N/A to fixed
Status: needs_review to closed

closed

moved to tpo/applications/tor-launcher#24428 (closed)