Make sure a comma never appears anywhere in a fallback entry
This possibly requires an update to our strong cleansing routines, or just adding a comment to them.
- Show closed items
Activity
-
Newest first Oldest first
-
Show all activity Show comments only Show history only
- teor changed milestone to %Tor: 0.3.3.x-final
changed milestone to %Tor: 0.3.3.x-final
I squashed the original branch into fallback-format-2-v3 on https://github.com/teor2345/tor.git
Trac:
Keywords: N/A deleted, review-group-28 addedPlease see my revised branch fallback-format-2-v4 at https://github.com/teor2345/tor.git
pastly found some whitelist and blacklist changes from #22321 (moved) that I'd accidentally included in some commits, so I took them out.
Commas are in fact removed Tested by adding
as,df
to all nicknames and verifying output nicknames only hadasdf
added. Also visually checked code that all%s
formatters in the fallback entry code had a call tocleanse_c_string
.LGTM, but make sure all
fallback-format-2-v4
are merge_ready.Trac:
Status: needs_review to merge_readyThis code is now in my branch fallback-code-2018-01 at https://github.com/teor2345/tor.git
Remove useless Cc
Trac:
Cc: teor@torproject.org to N/A- Trac closed
closed
- Trac changed time estimate to 48m
changed time estimate to 48m
- Trac added 48m of time spent
added 48m of time spent