OnionPerf showing >200% timeouts

https://metrics.torproject.org/torperf-failures.html

This doesn't make a lot of sense. Either it's incorrect or it's poorly explained.

added component::metrics/statistics owner::karsten priority::medium resolution::fixed reviewer::iwakeh severity::normal status::closed type::defect labels

Trac:

True. I'll take a look.

Trac:
Owner: metrics-team to karsten
Status: new to accepted

It looks like we implemented the database query for filling the "requests" column in the underlying CSV file as completed requests and later used the data in the graph as if it contained total requests made. The latter definition is also what we wrote in the specification, so I'd say let's change the database query. At least I can't come up with a good reason for keeping the current implementation.

Please review commit 0340088 in my task-24996 branch with a small fix. If that looks okay, I can deploy it easily on the server, and the next module run will fix the CSV file and graph.

Trac:
Status: accepted to needs_review

Added to my review list.

Trac:
Reviewer: N/A to iwakeh

Fine to be merged.

Trac:
Status: needs_review to merge_ready

Thanks for looking, merged! Starting a new module run now. We'll see in a few hours if this fixed the issue.

This is now fixed. Closing. Thanks!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

closed

mentioned in issue #25144 (moved)