Warn operators who set MyFamily that they must also set ContactInfo

We added this advice to the man page in 0.3.2.9 0.3.2.10, but a config warning could help, too.

The logic is:

If an operator sets MyFamily, and does not set ContactInfo:

• warn the operator that they should set ContactInfo

changed milestone to %Tor: 0.4.1.x-final

added 031-unreached-backport-maybe 032-unreached-backport-maybe 034-removed-20180328 034-triage-20180328 component::core tor/tor easy intro milestone::Tor: 0.4.1.x-final network-health points::0.1 priority::medium resolution::fixed reviewer::nickm severity::normal status::closed type::defect labels

Trac:
Description: We added this advice to the man page in 0.3.2.9, but a config warning could help, too.

to

We added this advice to the man page in 0.3.2.9 0.3.2.10, but a config warning could help, too.

The logic is:

If an operator sets MyFamily, and does not set ContactInfo:

• warn the operator that they should set ContactInfo

how about exiting with an error instead of just warning?

Exiting would be a good idea, if relays will be kicked out of the consensus when they have MyFamily but no ContactInfo. Otherwise, it seems disproportionate.

Trac:
Keywords: N/A deleted, 029-backport-maybe, 031-backport-maybe, 025-backport-maybe added

Trac:
Keywords: N/A deleted, 034-triage-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

Trac:
Keywords: N/A deleted, 034-removed-20180328 added

These tickets, tagged with 034-removed-*, are no longer in-scope for 0.3.4. We can reconsider any of them, if time permits.

Trac:
Milestone: Tor: 0.3.4.x-final to Tor: unspecified

0.3.1 is end of life, there are no more backports. Tagging with 031-unreached-backport instead.

Trac:
Keywords: N/A deleted, 031-unreached-backport added

0.3.1 is end of life, there are no more 0.3.1 maybe backports. Tagging with 031-unreached-backport-maybe.

Trac:
Keywords: 031-backport-maybe deleted, 031-unreached-backport-maybe added

Keywords does substrings in search, but not replace.

Trac:
Keywords: 031-unreached-backport deleted, N/A added

0.3.2 is end of life, so 032-backport is now 032-unreached-backport.

Trac:
Keywords: N/A deleted, 032-unreached-backport added

Tag 032-backport-maybe with 032-unreached-backport-maybe

Trac:
Keywords: 032-backport-maybe deleted, 032-unreached-backport-maybe added

Remove redundant 032-unreached-backport on 032-unreached-backport-maybe

Trac:
Keywords: 032-unreached-backport deleted, N/A added

Hoping it's fine, here is a patch

PR at: https://github.com/torproject/tor/pull/675 Commit: https://github.com/torproject/tor/pull/675/commits/cb1072790f17cd43787a41c04b36a24833fbf7ee

Trac:
Username: guigom

Trac:
Milestone: Tor: unspecified to Tor: 0.4.1.x-final
Status: new to needs_review

Trac:
Reviewer: N/A to nickm

looks good to me! Let's take it in 0.4.1 only.

Trac:
Status: needs_review to merge_ready

Merged in master. Thanks!

Trac:
Status: merge_ready to closed
Resolution: N/A to fixed

No backport.

Trac:
Keywords: 029-backport-maybe, 033-backport-maybe, 025-backport-maybe deleted, N/A added

Trac:
Keywords: N/A deleted, network-health added

closed

changed time estimate to 48m

moved to tpo/core/tor#25110 (closed)