Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #25178

Closed (moved)
Open
Opened Feb 08, 2018 by boklm@boklm

Running 'make testbuild' does not build the windows-x86_64 version

When running make testbuild we don't build anymore the Window 64 version.

I think this is caused by the change from commit dc51005d4944d6be9ca1c06331c3f9ee1cee51fc:

diff --git a/projects/release/config b/projects/release/config
index e53ea43..f0d95c7 100644
--- a/projects/release/config
+++ b/projects/release/config
@@ -29,7 +29,7 @@ targets:
       torbrowser-windows-i686: 1
   torbrowser-windows-x86_64:
     var:
-      torbrowser-windows-x86_64: 1
+      torbrowser-windows-x86_64: '[% c("var/alpha") || c("var/nightly") %]'
   torbrowser-osx-x86_64:
     var:
       torbrowser-osx-x86_64: 1

The testbuild build is started with:

$(rbm) build release --target testbuild --target torbrowser-all

At this point (in projects/release), var/alpha or var/nightly is not yet set, so var/torbrowser-windows-x86_64 is false.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#25178