hidden-service-dir description in dir-spec should reference HSDir protovers

Since 0.3.0, tor supports HSDir versions 2 and 3 by default, and advertises no hidden-service-dir VersionNums.

But the spec says: "If any VersionNum(s) are specified, this router supports those descriptor versions. If none are specified, it defaults to version 2 descriptors"

changed milestone to %Tor: 0.3.4.x-final

added 034-removed-20180328 034-triage-20180328 component::core tor/tor dir-spec doc. easy fast-fix milestone::Tor: 0.3.4.x-final owner::teor points::0.1 priority::medium prop224 resolution::implemented reviewer::dgoulet severity::normal status::closed tor-hs tor-spec type::defect labels

Trac:
Keywords: N/A deleted, tor-hs added

Trac:
Cc: N/A to metrics-team

Trac:
Keywords: N/A deleted, 034-triage-20180328 added

Per our triage process, these tickets are pending removal from 0.3.4.

Trac:
Keywords: N/A deleted, 034-removed-20180328 added

Woa... damn I wasn't aware of this VersionNum value from the hidden-service-dir line!... Phrack, we should then change the spec or start advertising versions!

But actually, it doesn't seem our code supports VersionNum, it just flags the "ri":

T01("hidden-service-dir",  K_HIDDEN_SERVICE_DIR,  NO_ARGS, NO_OBJ ),
  if (find_opt_by_keyword(tokens, K_HIDDEN_SERVICE_DIR)) {
    router->wants_to_be_hs_dir = 1;
  }

Ok, so maybe removing that VersionNum from the spec is the move and rely solely on protover.

Hmm, yes, NO_ARGS means Tor has never supported versions in the HSDir line,

So let's revise the spec to say that relays specify their HSDir versions in the proto line, or support v2 if there is no proto line.

Edit: spelling

Trac:
Keywords: N/A deleted, doc. prop224, easy added

Please see my branch bug25284 on https://github.com/teor2345/torspec.git

Trac:
Status: new to assigned
Keywords: N/A deleted, fast-fix added
Owner: N/A to teor

Trac:
Status: assigned to needs_review

lgtm;

Trac:
Reviewer: N/A to dgoulet
Status: needs_review to merge_ready

merged!

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

closed

changed time estimate to 48m

mentioned in issue #25712 (moved)

moved to tpo/core/tor#25284 (closed)