Consider removing tor2web mode

It sounds like tor2web mode wont work after the DoS protection code was added.

Would it make sense to get rid of this?

changed milestone to %Tor: 0.3.5.x-final

added 035-roadmap-master 035-triaged-in-20180711 component::core tor/tor milestone::Tor: 0.3.5.x-final owner::dgoulet priority::medium resolution::implemented reviewer::teor severity::normal status::closed tor-hs tor2web type::defect version::tor unspecified labels

+1000000000000000000000000000000000000000000000000000000000000000000000000000000000…

Edit: some browsers don't wrap long lines very well

Trac:
Keywords: N/A deleted, 035-proposed added

Trac:
Keywords: N/A deleted, tor2web added

Trac:
Keywords: 035-proposed deleted, 035-roadmap-proposed added

Trac:
Owner: N/A to dgoulet
Keywords: 035-roadmap-proposed deleted, 035-roadmap-master added
Status: new to accepted

Here it is: https://github.com/torproject/tor/pull/218

Branch: bug26367_035_01

Trac:
Keywords: N/A deleted, tor-hs added
Status: accepted to needs_review
Milestone: Tor: unspecified to Tor: 0.3.5.x-final

don't forget to update the manual https://www.torproject.org/docs/tor-manual.html.en

ENABLE_TOR2WEB_MODE sets NON_ANONYMOUS_MODE_ENABLED. I don't think there is any other supported way to set NON_ANONYMOUS_MODE_ENABLED.

So let's delete all references to NON_ANONYMOUS_MODE_ENABLED as well. I marked them on the pull request.

Trac:
Status: needs_review to needs_revision

Trac:
Keywords: N/A deleted, 035-triaged-in-20180711 added

Thanks teor!

I've pushed two extra commits to remove any mentions of them and their associated functions!

Trac:
Status: needs_revision to needs_review

Ok, looks good to me, let's get it merged, I opened #26788 (moved) for the unrelated make distcheck error.

Trac:
Reviewer: N/A to teor
Status: needs_review to merge_ready

Looks okay to merge, but needs a changes file.

Replying to nickm:

Looks okay to merge, but needs a changes file.

Fixup commit has it: 5b44e56e08f7922d

Merged yesterday :)

Trac:
Status: merge_ready to closed
Resolution: N/A to implemented

closed

mentioned in issue #26924 (moved)

moved to tpo/core/tor#26367 (closed)