Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #26478

Closed (moved)
Open
Opened Jun 24, 2018 by juga @juga💬

Unify bandwidth related terms in dir-spec and Tor code.

Unifying these terms would make following what these bandwidth do in the code and the spec less confusing. For instance:

  • what is called bandwidthrate [0] in the code when building the descriptor, it is called bandwidth-avg in dir-spec.txt [1].
  • what is called bandwidthcapacity [2] in the code, it is called bandwidth-observed in dir-spec.txt[1]

I don't know if it is prefered to modify terms in the spec or in the code.

It'd be also helpful to add formulae or more detailed descriptions on how the different bandwidth terms are generated in dir-spec.txt

[0] ​https://gitweb.torproject.org/tor.git/tree/src/or/router.c#n2370 [1] ​https://gitweb.torproject.org/torspec.git/tree/dir-spec.txt#n427 [2] https://gitweb.torproject.org/tor.git/tree/src/or/router.c#n2376

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Tor: unspecified
Milestone
Tor: unspecified
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#26478