Do not build the NSIS uninstaller for Firefox during `mach build stage-package`
Bug #26319 (moved) addressed the issue not packaging the Firefox DMG or EXE during the mach package step by using mach build stage-package. However, we still have an additional patch which fixes the error where the build fails trying to find the NSIS file for creating the uninstaller:
31:23.55 update.locale
31:25.74 cp: cannot stat 'instgen/helper.exe': No such file or directory
31:25.74 /var/tmp/build/firefox-a0efd2fcd6e9/toolkit/mozapps/installer/windows/nsis/makensis.mk:99: recipe for target 'uninstaller' failed
31:25.74 make[5]: *** [uninstaller] Error 1See the patch in 8d1c4c396034b2a (projects/firefox/nsis-uninstall.patch) which prevents the uninstaller from being built.
We should find a proper way to fix this so that we don't lose track of it.
To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information