Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #26699

Closed (moved)
Open
Opened Jul 09, 2018 by Karsten Loesing@karsten

Use temporary files for storing descriptor files fetched from remote CollecTor server

In #24153 (moved) we fixed a bug related to storing descriptor files fetched from a remote CollecTor server. We also briefly discussed using Files.createTempFile() for storing files, but we decided against doing that. Let's reconsider doing it when we have more time on our hands.

Copied from irl's comment on that other ticket: Files.createTempFile only creates the empty file and gives you a Path. The file is actually permanent (although the operating system may clean it up once the process exits) unless you open it with DELETE_ON_CLOSE on use .deleteOnExit(). ([[https://docs.oracle.com/javase/9/docs/api/java/nio/file/Files.html#createTempFile-java.nio.file.Path-java.lang.String-java.lang.String-java.nio.file.attribute.FileAttribute...-|ref]]) One benefit might be that using tmpfs for intermediate files reduces disk I/O and speeds things up. If we're memory constrained and it becomes an issue though, we should make sure that the default temporary directory is overridden to a location on disk.

To upload designs, you'll need to enable LFS and have admin enable hashed storage. More information
Assignee
Assign to
None
Milestone
None
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#26699