Skip to content

GitLab

  • Projects
  • Groups
  • Snippets
  • Help
    • Loading...
  • Help
    • Help
    • Support
    • Community forum
    • Submit feedback
    • Contribute to GitLab
  • Sign in
Trac
Trac
  • Project overview
    • Project overview
    • Details
    • Activity
  • Issues 246
    • Issues 246
    • List
    • Boards
    • Labels
    • Service Desk
    • Milestones
  • Operations
    • Operations
    • Metrics
    • Incidents
  • Analytics
    • Analytics
    • Value Stream
  • Wiki
    • Wiki
  • Members
    • Members
  • Collapse sidebar
  • Activity
  • Create a new issue
  • Issue Boards

GitLab is used only for code review, issue tracking and project management. Canonical locations for source code are still https://gitweb.torproject.org/ https://git.torproject.org/ and git-rw.torproject.org.

  • Legacy
  • TracTrac
  • Issues
  • #26919

Closed (moved)
Open
Opened Jul 24, 2018 by Karsten Loesing@karsten

Remove fingerprint parameter

We have two quite similar parameters: lookup and fingerprint. Both expect a full hex fingerprint and return a single relay or bridge (or more than just one when we implement #25448 (moved)).

The main difference between these two parameters is that fingerprint returns relays or bridges regardless of whether they have been running in the past week. There is no other way to access these documents other than by knowing the exact fingerprint of a relay or hashed fingerprint of a bridge. Unlike other parameters, the fingerprint does not even work with hashed relay fingerprints or hashed hashed bridge fingerprints.

Do we need to keep the fingerprint parameter with this somewhat special behavior?

We added the parameter four years ago for one of the EFF relay challenges. But is it still in use? And is that because clients really need to access older relays and bridges, or because their developers did not know about the lookup parameter?

Setting type to enhancement, because removing the fingerprint parameter would let us remove some special code from the code base.

However, if there are valid use cases to keep the fingerprint parameter, let's just collect them here and let the parameter in.

To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information
Assignee
Assign to
Onionoo 1.18.0
Milestone
Onionoo 1.18.0
Assign milestone
Time tracking
None
Due date
None
Reference: legacy/trac#26919